content/ppapi_plugin/ppapi.sb - Issue 10695185: Allow /dev/urandom from ppapi sandbox.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/ppapi_plugin/ppapi.sb

Issue 10695185: Allow /dev/urandom from ppapi sandbox. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Log type for failure. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/common/sandbox_mac_system_access_unittest.mm ('k') | no next file » | no next file with comments »

OLD	NEW
1 ;;	1 ;;

2 ;; Copyright (c) 2011 The Chromium Authors. All rights reserved.	2 ;; Copyright (c) 2011 The Chromium Authors. All rights reserved.

3 ;; Use of this source code is governed by a BSD-style license that can be	3 ;; Use of this source code is governed by a BSD-style license that can be

4 ;; found in the LICENSE file.	4 ;; found in the LICENSE file.

5 ;;	5 ;;

6	6

7 ; TODO(viettrungluu): Confirm that the exceptions below are needed.	7 ; TODO(viettrungluu): Confirm that the exceptions below are needed.

8	8

9 ; * The contents of content/common/common.sb are implicitly included here. *	9 ; * The contents of content/common/common.sb are implicitly included here. *

10	10

11 ; Needed for Fonts.	11 ; Needed for Fonts.

12 (allow file-read* (regex #"^/System/Library/Fonts($\|/)")) ; 10.5.6	12 (allow file-read* (regex #"^/System/Library/Fonts($\|/)")) ; 10.5.6

13 ; 10.6 for loading fonts in the renderer.	13 ; 10.6 for loading fonts in the renderer.

14 ; on 10.5 this is needed for the PDF plugin.	14 ; on 10.5 this is needed for the PDF plugin.

15 (allow file-read* (regex #"^/Library/Fonts($\|/)"))	15 (allow file-read* (regex #"^/Library/Fonts($\|/)"))

16 (allow mach-lookup (global-name "com.apple.FontObjectsServer")) ; 10.5.6	16 (allow mach-lookup (global-name "com.apple.FontObjectsServer")) ; 10.5.6

17 ;10.6_OR_ABOVE (allow mach-lookup (global-name "com.apple.FontServer")) ; 10.6	17 ;10.6_OR_ABOVE (allow mach-lookup (global-name "com.apple.FontServer")) ; 10.6

18	18

19 ; http://crbug.com/11269	19 ; http://crbug.com/11269

20 ;10.6_OR_ABOVE (allow file-read* (subpath "@USER_HOMEDIR_AS_LITERAL@/Library/Fon ts")) ; 10.6	20 ;10.6_OR_ABOVE (allow file-read* (subpath "@USER_HOMEDIR_AS_LITERAL@/Library/Fon ts")) ; 10.6

	21

	22 ; Bits of Adobe Flash wish to open /dev/urandom directly rather than

	23 ; using our cached file descriptor.

	24 (allow file-read* (literal "/dev/urandom"))
	jeremy 2012/07/16 11:36:40 Any chance that just file-read-data is enough here Any chance that just file-read-data is enough here? Scott Hess - ex-Googler 2012/07/16 16:36:42 Done. Writing to the file can be used to add entr Show quoted text On 2012/07/16 11:36:40, jeremy wrote: > Any chance that just file-read-data is enough here? Done. Writing to the file can be used to add entropy, and AFAICT it would be safe to allow, but I suspect that any sandboxed plugin which was doing this would probably be doing the wrong thing.
OLD	NEW