Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Issue 10695176: Fix compilation for ARM/uClibc (Closed)

Created:
8 years, 5 months ago by remi.duraffort
Modified:
8 years, 5 months ago
Reviewers:
Sven Panne, ulan, danno, Yang, digit1
CC:
v8-dev
Base URL:
http://github.com/v8/v8.git@master
Visibility:
Public.

Description

Fix compilation for ARM/uClibc BUG=compile for ARM with uClibc

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/platform-linux.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
remi.duraffort
8 years, 5 months ago (2012-07-12 15:16:01 UTC) #1
digit1
https://chromiumcodereview.appspot.com/10695176/diff/1/src/platform-linux.cc File src/platform-linux.cc (right): https://chromiumcodereview.appspot.com/10695176/diff/1/src/platform-linux.cc#newcode1029 src/platform-linux.cc:1029: (__UCLIBC__ != 1)) fwiw, I'm working on a similar ...
8 years, 5 months ago (2012-07-13 08:33:21 UTC) #2
digit1
For the record, my (slightly conflicting) patch is at https://chromiumcodereview.appspot.com/10690163/ Let me know if you ...
8 years, 5 months ago (2012-07-13 12:36:58 UTC) #3
remi.duraffort
https://chromiumcodereview.appspot.com/10695176/diff/1/src/platform-linux.cc File src/platform-linux.cc (right): https://chromiumcodereview.appspot.com/10695176/diff/1/src/platform-linux.cc#newcode1029 src/platform-linux.cc:1029: (__UCLIBC__ != 1)) > What about just using this ...
8 years, 5 months ago (2012-07-16 08:43:23 UTC) #4
remi.duraffort
Path updated to only test for the definition of __UCLIBC__. This fix the compilation on ...
8 years, 5 months ago (2012-07-16 09:01:32 UTC) #5
Sven Panne
Could you please open a new issue with the correct base URL https://v8.googlecode.com/svn/branches/bleeding_edge and make ...
8 years, 5 months ago (2012-07-16 09:59:52 UTC) #6
remi.duraffort
8 years, 5 months ago (2012-07-16 11:31:35 UTC) #7
I have created another issue with the correct base-url and wrapped at 80 at:
https://chromiumcodereview.appspot.com/10784012

I compiled v8 with this patch on both armv7_glibc and armv7_uclibc.


Regards.

Powered by Google App Engine
This is Rietveld 408576698