[RFC] Associate AST nodes with HIstructions when building HGraph.

Associate AST nodes with HIstructions when building HGraph.

Then use this info in ssa codegen to provide source locations for generated code.

R=floitsch@google.com,kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=9711

[floitsch, 2012-07-12 16:48:06]

Looping in Nicolas and Peter who probably have opinions, too.

I wonder if having the source-location directly inside the nodes is not better.

[podivilov, 2012-07-12 17:15:52]

On 2012/07/12 16:48:06, floitsch wrote:
> Looping in Nicolas and Peter who probably have opinions, too.
> 
> I wonder if having the source-location directly inside the nodes is not
better.

Yes, it's probably better, see new patch.

[podivilov, 2012-07-17 12:46:57]

ping.

[floitsch, 2012-07-17 14:46:53]

LGTM.

https://chromiumcodereview.appspot.com/10695174/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10695174/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:1645: target.sourceToken =
node.getBeginToken();
Maybe:
attachPosition(target, node);
If this function returns the node we could maybe use it in one line for some
nodes:
HInstruction n = attachPosition(new HStatic( ... ), node);

https://chromiumcodereview.appspot.com/10695174/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10695174/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:662:
buffer.setSourceLocation(work.element, node.sourceToken);
I'm not sure this is the only place where we would like to attach information,
but it's probably a good starting point.

https://chromiumcodereview.appspot.com/10695174/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10695174/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/nodes.dart:708: Token sourceToken;
I'm not sure we should expose the position-type to the SSA nodes.
I'm leaning towards "Dynamic sourceInformation" (after all, the SSA nodes don't
care at all, what is in there).
But I wouldn't be surprised if there are different opinions.
Maybe as compromise: Token sourcePosition; ?

[podivilov, 2012-07-17 16:42:46]

Thanks!

https://chromiumcodereview.appspot.com/10695174/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10695174/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:1645: target.sourceToken =
node.getBeginToken();
On 2012/07/17 14:46:53, floitsch wrote:
> Maybe:
> attachPosition(target, node);
> If this function returns the node we could maybe use it in one line for some
> nodes:
> HInstruction n = attachPosition(new HStatic( ... ), node);

Done.

https://chromiumcodereview.appspot.com/10695174/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10695174/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/nodes.dart:708: Token sourceToken;
On 2012/07/17 14:46:53, floitsch wrote:
> I'm not sure we should expose the position-type to the SSA nodes.
> I'm leaning towards "Dynamic sourceInformation" (after all, the SSA nodes
don't
> care at all, what is in there).
> But I wouldn't be surprised if there are different opinions.
> Maybe as compromise: Token sourcePosition; ?

OK, let's declare it as "Token sourcePosition" for now, it would be easy to fix
if anyone asks.