Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 10695170: init AndroidCommand after the device online to root it (Closed)

Created:
8 years, 5 months ago by Wei James(wistoch)
Modified:
8 years, 5 months ago
Reviewers:
John Grabowski, bulach
CC:
chromium-reviews
Visibility:
Public.

Description

init AndroidCommand after the device online to root it AndroidCommand object will root the device when it is created. If this happened before the device is online, error will appear. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146306

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix according to bulach's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/android/emulator.py View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Wei James(wistoch)
# 07/12/12 13:16:15: Unrecognized output from adb root: error: device not found
8 years, 5 months ago (2012-07-12 05:16:15 UTC) #1
bulach
lgtm, thanks! http://codereview.chromium.org/10695170/diff/1/build/android/emulator.py File build/android/emulator.py (right): http://codereview.chromium.org/10695170/diff/1/build/android/emulator.py#newcode224 build/android/emulator.py:224: a.Adb().SetTargetSerial(self.device) nit: 224 is no longer necessary..
8 years, 5 months ago (2012-07-12 07:33:38 UTC) #2
Wei James(wistoch)
http://codereview.chromium.org/10695170/diff/1/build/android/emulator.py File build/android/emulator.py (right): http://codereview.chromium.org/10695170/diff/1/build/android/emulator.py#newcode224 build/android/emulator.py:224: a.Adb().SetTargetSerial(self.device) On 2012/07/12 07:33:38, bulach wrote: > nit: 224 ...
8 years, 5 months ago (2012-07-12 07:39:49 UTC) #3
bulach
lgtm, thanks!
8 years, 5 months ago (2012-07-12 08:09:51 UTC) #4
Wei James(wistoch)
On 2012/07/12 08:09:51, bulach wrote: > lgtm, thanks! thanks.
8 years, 5 months ago (2012-07-12 08:11:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10695170/4001
8 years, 5 months ago (2012-07-12 08:11:25 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 09:20:31 UTC) #7
Change committed as 146306

Powered by Google App Engine
This is Rietveld 408576698