Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 10695161: Bluetooth API: test discovery callback. (Closed)

Created:
8 years, 5 months ago by bryeung
Modified:
8 years, 5 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Bluetooth API: test discovery callback. TEST=added BUG=132616 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146271

Patch Set 1 #

Patch Set 2 : fix patch #

Total comments: 4

Patch Set 3 : review comments #

Patch Set 4 : upload against correct base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -25 lines) Patch
M chrome/browser/extensions/api/bluetooth/bluetooth_apitest_chromeos.cc View 1 3 9 chunks +46 lines, -24 lines 0 comments Download
A + chrome/test/data/extensions/api_test/bluetooth/test_discovery.html View 3 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/bluetooth/test_discovery.js View 1 2 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bryeung
8 years, 5 months ago (2012-07-11 21:43:47 UTC) #1
miket_OOO
LGTM % nits. http://codereview.chromium.org/10695161/diff/2001/chrome/test/data/extensions/api_test/bluetooth/test_discovery.js File chrome/test/data/extensions/api_test/bluetooth/test_discovery.js (right): http://codereview.chromium.org/10695161/diff/2001/chrome/test/data/extensions/api_test/bluetooth/test_discovery.js#newcode16 chrome/test/data/extensions/api_test/bluetooth/test_discovery.js:16: chrome.test.runTests([ testDiscovery ]); We're not super-consistent ...
8 years, 5 months ago (2012-07-11 21:49:46 UTC) #2
bryeung
Sorry: that was a bit sloppy of me. Thanks for catching those things. http://codereview.chromium.org/10695161/diff/2001/chrome/test/data/extensions/api_test/bluetooth/test_discovery.js File ...
8 years, 5 months ago (2012-07-12 01:02:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryeung@chromium.org/10695161/8001
8 years, 5 months ago (2012-07-12 01:02:58 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 02:13:49 UTC) #5
Change committed as 146271

Powered by Google App Engine
This is Rietveld 408576698