Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: runtime/vm/object_test.cc

Issue 10695136: Use class id instead of class in subtype test cache. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/stub_code_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
===================================================================
--- runtime/vm/object_test.cc (revision 9557)
+++ runtime/vm/object_test.cc (working copy)
@@ -2646,14 +2646,14 @@
EXPECT_EQ(0, cache.NumberOfChecks());
const TypeArguments& targ_0 = TypeArguments::Handle(TypeArguments::New(2));
const TypeArguments& targ_1 = TypeArguments::Handle(TypeArguments::New(3));
- cache.AddCheck(empty_class, targ_0, targ_1, Bool::Handle(Bool::True()));
+ cache.AddCheck(empty_class.id(), targ_0, targ_1, Bool::Handle(Bool::True()));
EXPECT_EQ(1, cache.NumberOfChecks());
- Class& test_class = Class::Handle();
+ intptr_t test_class_id = -1;
AbstractTypeArguments& test_targ_0 = AbstractTypeArguments::Handle();
AbstractTypeArguments& test_targ_1 = AbstractTypeArguments::Handle();
Bool& test_result = Bool::Handle();
- cache.GetCheck(0, &test_class, &test_targ_0, &test_targ_1, &test_result);
- EXPECT_EQ(empty_class.raw(), test_class.raw());
+ cache.GetCheck(0, &test_class_id, &test_targ_0, &test_targ_1, &test_result);
+ EXPECT_EQ(empty_class.id(), test_class_id);
EXPECT_EQ(targ_0.raw(), test_targ_0.raw());
EXPECT_EQ(targ_1.raw(), test_targ_1.raw());
EXPECT_EQ(Bool::True(), test_result.raw());
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/stub_code_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698