Issue 10695130: Fix a memory leak in RulesRegistryStorageDelegate.

Issue 10695130: Fix a memory leak in RulesRegistryStorageDelegate. (Closed)

Created:
8 years, 5 months ago by Matt Perry

Modified:
8 years, 5 months ago

Reviewers:
battre

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, Aaron Boodman, pam+watch_chromium.org, timurrrr+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix a memory leak in RulesRegistryStorageDelegate. The Inner class was being leaked because it was marked DeleteOnUIThread, but the last reference is released after the UI message loop goes away. So I removed that trait. BUG=133449 TEST=no Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146205

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -36 lines)			Patch
M	chrome/browser/extensions/api/declarative/rules_registry_service.h	View	2 chunks	+2 lines, -0 lines	2 comments	Download
M	chrome/browser/extensions/api/declarative/rules_registry_service.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative/rules_registry_storage_delegate.h	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative/rules_registry_storage_delegate.cc	View	6 chunks	+23 lines, -15 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	2 chunks	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

battre

lgtm http://codereview.chromium.org/10695130/diff/1/chrome/browser/extensions/api/declarative/rules_registry_service.h File chrome/browser/extensions/api/declarative/rules_registry_service.h (right): http://codereview.chromium.org/10695130/diff/1/chrome/browser/extensions/api/declarative/rules_registry_service.h#newcode71 chrome/browser/extensions/api/declarative/rules_registry_service.h:71: std::vector<RulesRegistryStorageDelegate*> delegates_; Add comment that delegates are owned ...

8 years, 5 months ago (2012-07-11 09:16:31 UTC) #2

battre

lgtm lgtm http://codereview.chromium.org/10695130/diff/1/chrome/browser/extensions/api/declarative/rules_registry_service.h File chrome/browser/extensions/api/declarative/rules_registry_service.h (right): http://codereview.chromium.org/10695130/diff/1/chrome/browser/extensions/api/declarative/rules_registry_service.h#newcode71 chrome/browser/extensions/api/declarative/rules_registry_service.h:71: std::vector<RulesRegistryStorageDelegate*> delegates_; Add comment that delegates are ...

8 years, 5 months ago (2012-07-11 09:16:31 UTC) #3

Matt Perry

8 years, 5 months ago (2012-07-11 21:15:28 UTC) #4

http://codereview.chromium.org/10695130/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/declarative/rules_registry_service.h (right):

http://codereview.chromium.org/10695130/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/declarative/rules_registry_service.h:71:
std::vector<RulesRegistryStorageDelegate*> delegates_;
On 2012/07/11 09:16:32, battre wrote:
> Add comment that delegates are owned by rules_registries?

Done.

Expand Messages | Collapse Messages