Issue 10695122: chromeos: Use chrome::ShowWebDialog to avoid depending in web_dialog_view.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10695122: chromeos: Use chrome::ShowWebDialog to avoid depending in web_dialog_view.h (Closed)

Created:
8 years, 5 months ago by tfarina

Modified:
8 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

chromeos: Use chrome::ShowWebDialog to avoid depending in web_dialog_view.h This removes the dependency in chrome/browser/ui/views/web_dialog_view.h from chromeos. BUG=125846 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146019

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -18 lines)			Patch
M	chrome/browser/chromeos/choose_mobile_network_dialog.cc	View	2 chunks	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_web_dialog.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/sim_dialog_delegate.cc	View	2 chunks	+5 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm