Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: src/objects-inl.h

Issue 10695120: Ensure that all descriptors have a valid enumeration index, and replace NextEnumIndex with LastAdde… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/property.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2077 matching lines...) Expand 10 before | Expand all | Expand 10 after
2088 GetValue(descriptor_number), 2088 GetValue(descriptor_number),
2089 GetDetails(descriptor_number)); 2089 GetDetails(descriptor_number));
2090 } 2090 }
2091 2091
2092 2092
2093 void DescriptorArray::Set(int descriptor_number, 2093 void DescriptorArray::Set(int descriptor_number,
2094 Descriptor* desc, 2094 Descriptor* desc,
2095 const WhitenessWitness&) { 2095 const WhitenessWitness&) {
2096 // Range check. 2096 // Range check.
2097 ASSERT(descriptor_number < number_of_descriptors()); 2097 ASSERT(descriptor_number < number_of_descriptors());
2098 ASSERT(desc->GetDetails().index() > 0);
2098 2099
2099 NoIncrementalWriteBarrierSet(this, 2100 NoIncrementalWriteBarrierSet(this,
2100 ToKeyIndex(descriptor_number), 2101 ToKeyIndex(descriptor_number),
2101 desc->GetKey()); 2102 desc->GetKey());
2102 NoIncrementalWriteBarrierSet(this, 2103 NoIncrementalWriteBarrierSet(this,
2103 ToValueIndex(descriptor_number), 2104 ToValueIndex(descriptor_number),
2104 desc->GetValue()); 2105 desc->GetValue());
2105 NoIncrementalWriteBarrierSet(this, 2106 NoIncrementalWriteBarrierSet(this,
2106 ToDetailsIndex(descriptor_number), 2107 ToDetailsIndex(descriptor_number),
2107 desc->GetDetails().AsSmi()); 2108 desc->GetDetails().AsSmi());
(...skipping 3197 matching lines...) Expand 10 before | Expand all | Expand 10 after
5305 #undef WRITE_UINT32_FIELD 5306 #undef WRITE_UINT32_FIELD
5306 #undef READ_SHORT_FIELD 5307 #undef READ_SHORT_FIELD
5307 #undef WRITE_SHORT_FIELD 5308 #undef WRITE_SHORT_FIELD
5308 #undef READ_BYTE_FIELD 5309 #undef READ_BYTE_FIELD
5309 #undef WRITE_BYTE_FIELD 5310 #undef WRITE_BYTE_FIELD
5310 5311
5311 5312
5312 } } // namespace v8::internal 5313 } } // namespace v8::internal
5313 5314
5314 #endif // V8_OBJECTS_INL_H_ 5315 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/property.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698