Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 10695114: MIPS: Rename "mips" arch to "mipsel" in the GYP build. (Closed)

Created:
8 years, 5 months ago by palfia
Modified:
8 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Rename "mips" arch to "mipsel" in the GYP build. In the traditional MIPS naming scheme, "mips" is used for big-endian mips and "mipsel" is used for little-endian mips. In V8 the "mips" build is little-endian, so the "mips" target is renamed to "mipsel" to be compliant with the traditional MIPS naming scheme. This change is also required for supporting the Chromium project on MIPS. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12047

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M Makefile View 2 chunks +5 lines, -1 line 0 comments Download
M build/common.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M build/standalone.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 3 chunks +3 lines, -3 lines 0 comments Download
M test/mozilla/mozilla.status View 1 2 chunks +6 lines, -6 lines 0 comments Download
M test/sputnik/sputnik.status View 1 1 chunk +1 line, -1 line 0 comments Download
M test/test262/test262.status View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download
M tools/test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/test-wrapper-gypbuild.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
palfia
8 years, 5 months ago (2012-07-06 15:11:54 UTC) #1
Jakob Kummerow
LGTM. I'll land this on Monday.
8 years, 5 months ago (2012-07-06 16:52:24 UTC) #2
Jakob Kummerow
Come to think of it, these changes aren't quite enough; in particular, they will make ...
8 years, 5 months ago (2012-07-07 12:34:37 UTC) #3
palfia
On 2012/07/07 12:34:37, Jakob wrote: > Come to think of it, these changes aren't quite ...
8 years, 5 months ago (2012-07-09 17:07:21 UTC) #4
palfia
http://chromiumcodereview.appspot.com/10695114/diff/1/build/common.gypi File build/common.gypi (right): http://chromiumcodereview.appspot.com/10695114/diff/1/build/common.gypi#newcode167 build/common.gypi:167: 'mipscompiler': '<!($(echo ${CXX:-$(which g++)}) -v 2>&1 | grep -q ...
8 years, 5 months ago (2012-07-09 17:07:41 UTC) #5
Jakob Kummerow
LGTM, landing. Found another missing update: test/cctest/cctest.gyp. Fixed that for you. Note that our MIPS ...
8 years, 5 months ago (2012-07-11 15:12:43 UTC) #6
Jakob Kummerow
Oops, forgot to specify the change's author when committing. Sorry.
8 years, 5 months ago (2012-07-11 15:17:23 UTC) #7
Paul Lind
On 2012/07/11 15:12:43, Jakob wrote: > Note that our MIPS buildbot will be red now ...
8 years, 5 months ago (2012-07-11 15:20:15 UTC) #8
Jakob Kummerow
On 2012/07/11 15:20:15, Paul Lind wrote: > Hi Jakob - Just noticed now that you ...
8 years, 5 months ago (2012-07-11 15:23:36 UTC) #9
palfia
8 years, 5 months ago (2012-07-11 15:27:44 UTC) #10
On 2012/07/11 15:17:23, Jakob wrote:
> Oops, forgot to specify the change's author when committing. Sorry.

No problem, thanks for landing!

Powered by Google App Engine
This is Rietveld 408576698