Issue 10695078: Prepare push to trunk. Now working on version 3.12.8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10695078: Prepare push to trunk. Now working on version 3.12.8. (Closed)

Created:
8 years, 5 months ago by Michael Starzinger

Modified:
8 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare push to trunk. Now working on version 3.12.8. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11977

Patch Set 2 : Addressed comments by Yang Guo. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	ChangeLog	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with a comment. https://chromiumcodereview.appspot.com/10695078/diff/1/ChangeLog File ChangeLog (right): https://chromiumcodereview.appspot.com/10695078/diff/1/ChangeLog#newcode6 ChangeLog:6: Made MACOSX_DEPLOYMENT_TARGET configurable. Maybe add ...

8 years, 5 months ago (2012-07-03 09:32:39 UTC) #2

Michael Starzinger

8 years, 5 months ago (2012-07-03 09:37:52 UTC) #3

Addressed comments. Landing.

https://chromiumcodereview.appspot.com/10695078/diff/1/ChangeLog
File ChangeLog (right):

https://chromiumcodereview.appspot.com/10695078/diff/1/ChangeLog#newcode6
ChangeLog:6: Made MACOSX_DEPLOYMENT_TARGET configurable.
On 2012/07/03 09:32:40, Yang wrote:
> Maybe add that it was made configurable *in GYP*.

Done.

Expand Messages | Collapse Messages

Issue 10695078: Prepare push to trunk. Now working on version 3.12.8. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Yang Guo. #

Messages