chrome/browser/extensions/api/extension_action/extension_script_badge_api.cc - Issue 10695070: Implement scriptBadge.requestToAct.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/extension_action/extension_script_badge_api.cc

Issue 10695070: Implement scriptBadge.requestToAct. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix more of Aaron's comments. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/extensions/api/extension_action/extension_script_badge_ api.h"

	6

	7 #include "chrome/browser/extensions/extension_tab_helper.h"

	8 #include "chrome/browser/extensions/location_bar_controller.h"

	9 #include "content/public/browser/web_contents.h"

	10

	11 ScriptBadgeGetAttentionFunction::~ScriptBadgeGetAttentionFunction() {}

	12

	13 bool ScriptBadgeGetAttentionFunction::RunExtensionAction() {

	14 tab_helper().location_bar_controller()->GetAttentionFor(extension_id());
	Aaron Boodman 2012/07/16 21:46:09 I guess right now it doesn't matter (because get-a I guess right now it doesn't matter (because get-attention state isn't visually different), but when you get to that part, I think (but am not sure) that is-running state should override get-attention state. Jeffrey Yasskin 2012/07/16 21:58:28 Yep. I'm planning to do that inside GetAttentionFo Show quoted text On 2012/07/16 21:46:09, Aaron Boodman wrote: > I guess right now it doesn't matter (because get-attention state isn't visually > different), but when you get to that part, I think (but am not sure) that > is-running state should override get-attention state. Yep. I'm planning to do that inside GetAttentionFor(), but until the next change I'm not even tracking which state the badge is in.
	15 return true;

	16 }

OLD	NEW