Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 10695062: Improve download performance statistics. (Closed)

Created:
8 years, 5 months ago by Randy Smith (Not in Mondays)
Modified:
8 years, 5 months ago
Reviewers:
benjhayden
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Improve download performance statistics. I've removed the questionable Download.BandwidthNetwork measurement, and replaced it with measurements designed to answer the question "What is the bottleneck for a download?" Specfically, this includes two new statistics: * Download.DiskBandwidthUsedPercentage: The percentage of the available disk bandwith that was actually used. 100% implies that the disk was the performance bottleneck. * Download.ResourceHandlerBlockedPercentage: The percentage of the time it was alive that the DownloadResourceHandler was throttled for performance reasons. 0% implies that the network was the performance bottleneck. R=benjhayden@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145320

Patch Set 1 #

Patch Set 2 : Fixes from self code review. #

Patch Set 3 : Avoid division by zero errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M content/browser/download/download_file_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/download/download_resource_handler.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/download/download_stats.h View 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/download/download_stats.cc View 1 2 2 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Randy Smith (Not in Mondays)
Ben: I had a chat with Jim Roskind as part of the histograms.xml code review, ...
8 years, 5 months ago (2012-07-02 16:53:36 UTC) #1
benjhayden
lgtm
8 years, 5 months ago (2012-07-02 17:19:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/10695062/2001
8 years, 5 months ago (2012-07-02 17:39:04 UTC) #3
commit-bot: I haz the power
Try job failure for 10695062-2001 (retry) on win_rel for steps "browser_tests, content_unittests". It's a second ...
8 years, 5 months ago (2012-07-02 20:22:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/10695062/5002
8 years, 5 months ago (2012-07-03 15:26:16 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-03 16:53:33 UTC) #6
Change committed as 145320

Powered by Google App Engine
This is Rietveld 408576698