Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 10695060: Get a minimal all.gyp working for iOS (Closed)

Created:
8 years, 5 months ago by stuartmorgan
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Get a minimal all.gyp working for iOS Moves targets that will likely never exist for iOS to a !ios condition block. For the rest of the targets, moves all dependencies to a !ios condition block, with the plan being to move many of them back to the main dependencies section as they come online. While this is arguably uglier than using a separate file in the short term, in the long term the targets will look essentially like this just with many of the dependencies moved back where they were, so this is a clearer step toward the final state. Note that this target won't actually build yet; this is just enough that 'gclient runhooks' will succeed. BUG=None TEST=None (an FYI bot building all.gyp:All will follow later) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -129 lines) Patch
M build/all.gyp View 3 chunks +162 lines, -129 lines 0 comments Download
M build/common.gypi View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stuartmorgan
8 years, 5 months ago (2012-07-02 16:17:48 UTC) #1
Mark Mentovai
LGTM
8 years, 5 months ago (2012-07-02 16:51:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10695060/1
8 years, 5 months ago (2012-07-02 20:45:36 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-02 22:10:55 UTC) #4
Change committed as 145205

Powered by Google App Engine
This is Rietveld 408576698