Factor out a Histogram class from HistogramTimer, and use it to measure external fragmentation

src/counters.h

 // Copyright 2007-2008 the V8 project authors. All rights reserved.

[Michael Starzinger, 2012/07/02 21:09:56]

2012

[jochen (gone - plz use gerrit), 2012/07/13 09:48:08]

Done.

 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
@@ skipping 151 matching lines @@
   int* GetInternalPointer() {
     int* loc = GetPtr();
     ASSERT(loc != NULL);
     return loc;
   }
 
  protected:
   // Returns the cached address of this counter location.
   int* GetPtr() {
     if (lookup_done_)
       return ptr_;

[Michael Starzinger, 2012/07/02 21:09:56]

Aww, that should be on one line.

[jochen (gone - plz use gerrit), 2012/07/13 09:48:08]

Done.

     lookup_done_ = true;
     ptr_ = FindLocationInStatsTable();
     return ptr_;
   }
 
  private:
   int* FindLocationInStatsTable() const;
 };
 
 // StatsCounterTimer t = { { L"t:foo", NULL, false }, 0, 0 };
 struct StatsCounterTimer {
   StatsCounter counter_;
 
   int64_t start_time_;
   int64_t stop_time_;
 
   // Start the timer.
   void Start();
 
   // Stop the timer and record the results.
   void Stop();
 
   // Returns true if the timer is running.
   bool Running() {
     return counter_.Enabled() && start_time_ != 0 && stop_time_ == 0;
   }
 };
 
-// A HistogramTimer allows distributions of results to be created
-// HistogramTimer t = { L"foo", NULL, false, 0, 0 };
-struct HistogramTimer {
+// Similar to StatsCounter, the class Histogram represents a dynamically

[Michael Starzinger, 2012/07/02 21:09:56]

Can we remove the reference to StatsCounter here? Just "A Histogram represents
[...]"

[jochen (gone - plz use gerrit), 2012/07/13 09:48:08]

Done.

+// created histogram in the StatsTable.
+//
+// This class is designed to be POD initialized.  It will be registered with
+// the histogram system on first use.  For example:
+//   Histogram h = { "myhist", 0, 10000, 50, NULL, false };
+struct Histogram {
   const char* name_;
+  int min_;
+  int max_;
+  int num_buckets_;
   void* histogram_;
   bool lookup_done_;
 
-  int64_t start_time_;
-  int64_t stop_time_;
+  // Add a single sample to this histogram.
+  void AddSample(int sample);
 
-  // Start the timer.
-  void Start();
-
-  // Stop the timer and record the results.
-  void Stop();
-
-  // Returns true if the timer is running.
-  bool Running() {
-    return (histogram_ != NULL) && (start_time_ != 0) && (stop_time_ == 0);
+  // Is this histogram enabled?
+  // Returns false if table is full.

[Michael Starzinger, 2012/07/02 21:09:56]

Let's turn that into just one line: "Returns true if this histogram is enabled."

[jochen (gone - plz use gerrit), 2012/07/13 09:48:08]

Done.

+  bool Enabled() {
+    return GetHistogram() != NULL;
   }
 
  protected:
   // Returns the handle to the histogram.
   void* GetHistogram() {
     if (!lookup_done_) {
       lookup_done_ = true;
       histogram_ = CreateHistogram();
     }
     return histogram_;
   }
 
  private:
   void* CreateHistogram() const;
 };
 
+// A HistogramTimer allows distributions of results to be created
+// HistogramTimer t = { {L"foo", 0, 10000, 50, NULL, false}, 0, 0 };
+struct HistogramTimer {
+  Histogram histogram_;
+
+  int64_t start_time_;
+  int64_t stop_time_;
+
+  // Start the timer.
+  void Start();
+
+  // Stop the timer and record the results.
+  void Stop();
+
+  // Returns true if the timer is running.
+  bool Running() {
+    return histogram_.Enabled() && (start_time_ != 0) && (stop_time_ == 0);
+  }
+};
+
 // Helper class for scoping a HistogramTimer.
 class HistogramTimerScope BASE_EMBEDDED {
  public:
   explicit HistogramTimerScope(HistogramTimer* timer) :
   timer_(timer) {
     timer_->Start();
   }
   ~HistogramTimerScope() {
     timer_->Stop();
   }
  private:
   HistogramTimer* timer_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_COUNTERS_H_