Factor out a Histogram class from HistogramTimer, and use it to measure external fragmentation

src/counters.cc

 // Copyright 2007-2008 the V8 project authors. All rights reserved.

[Michael Starzinger, 2012/07/02 21:09:56]

2012

[jochen (gone - plz use gerrit), 2012/07/13 09:48:08]

Done.

 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
@@ skipping 45 matching lines @@
 void StatsCounterTimer::Stop() {
   if (!counter_.Enabled())
     return;
   stop_time_ = OS::Ticks();
 
   // Compute the delta between start and stop, in milliseconds.
   int milliseconds = static_cast<int>(stop_time_ - start_time_) / 1000;
   counter_.Increment(milliseconds);
 }
 
+void Histogram::AddSample(int sample) {
+  if (Enabled())

[Michael Starzinger, 2012/07/02 21:09:56]

Curly brackets if not on one line.

[jochen (gone - plz use gerrit), 2012/07/13 09:48:08]

Done.

+    Isolate::Current()->stats_table()->AddHistogramSample(histogram_, sample);
+}
+
+void* Histogram::CreateHistogram() const {
+  return Isolate::Current()->stats_table()->
+      CreateHistogram(name_, min_, max_, num_buckets_);
+}
+
 // Start the timer.
 void HistogramTimer::Start() {
-  if (GetHistogram() != NULL) {
+  if (histogram_.Enabled()) {
     stop_time_ = 0;
     start_time_ = OS::Ticks();
   }
 }
 
 // Stop the timer and record the results.
 void HistogramTimer::Stop() {
-  if (histogram_ != NULL) {
+  if (histogram_.Enabled()) {
     stop_time_ = OS::Ticks();
 
     // Compute the delta between start and stop, in milliseconds.
     int milliseconds = static_cast<int>(stop_time_ - start_time_) / 1000;
-    Isolate::Current()->stats_table()->
-        AddHistogramSample(histogram_, milliseconds);
+    histogram_.AddSample(milliseconds);
   }
 }
 
-
-void* HistogramTimer::CreateHistogram() const {
-  return Isolate::Current()->stats_table()->
-      CreateHistogram(name_, 0, 10000, 50);
-}
-
 } }  // namespace v8::internal