Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 10695026: Merge 121019 - REGRESSION(r117738):[Forms] validationMessage IDL attribute should not have range ov… (Closed)

Created:
8 years, 5 months ago by yosin_UTC9
Modified:
8 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 121019 - REGRESSION(r117738):[Forms] validationMessage IDL attribute should not have range overflow message if value isn't range overflow https://bugs.webkit.org/show_bug.cgi?id=89736 Reviewed by Kent Tamura. Source/WebCore: Tests: fast/forms/date/input-date-validation-message.html fast/forms/number/input-number-validation-message.html fast/forms/range/input-range-validation-message.html This patch changes comparison operator for range overflow message in InputType::validationMessage(). * html/InputType.cpp: (WebCore::InputType::validationMessage): LayoutTests: Tests for HTMLInputElement.validationMessage attribute. * fast/forms/date/input-date-validation-message-expected.txt: Added. * fast/forms/date/input-date-validation-message.html: Added. * fast/forms/number/input-number-validation-message-expected.txt: Added. * fast/forms/number/input-number-validation-message.html: Added. * fast/forms/range/input-range-validation-message-expected.txt: Added. * fast/forms/range/input-range-validation-message.html: Added. TBR=yosin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-5 lines, --5 lines) Patch
A + LayoutTests/fast/forms/date/input-date-validation-message.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/date/input-date-validation-message-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/number/input-number-validation-message.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/number/input-number-validation-message-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/range/input-range-validation-message.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/range/input-range-validation-message-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/html/InputType.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
yosin_UTC9
8 years, 5 months ago (2012-06-28 03:22:22 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698