Adding gdb-add-index script from Redhat's gdb rpm.

Adding gdb-add-index script from Redhat's gdb rpm.

For linux users who are going to debug chromium, running gdb-add-index
on the binary first will significantly speed up debugger start time.

The originating RPM is gdb-7.4.50.20120603-1.1.x86_64.rpm. The script is
just a bash script version of the instructions in the gdb man page.

BUG=none
TEST=ran it on a statically linked browser_tests locally. verfied .gdb_index section exists
and that gdb does startup faster (from ~20 secs to ~3 seconds)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144644

[awong, 2012-06-28 01:18:31]

Moved the file location.

[nsylvain, 2012-06-28 01:24:19]

lgtm

[cmp, 2012-06-28 01:25:07]

lgtm with nit

https://chromiumcodereview.appspot.com/10695024/diff/1/build/gdb-add-index
File build/gdb-add-index (right):

https://chromiumcodereview.appspot.com/10695024/diff/1/build/gdb-add-index#ne...
build/gdb-add-index:26: objcopy --add-section .gdb_index="${file}.gdb-index"
--set-section-flags .gdb_index=readonly "$file" "$file"
nit: can you wrap this at 80 chars?

[awong, 2012-06-28 01:26:00]

I snagged this file verbatim from the redhat sources so I'd prefer not to
touch it.


On Wed, Jun 27, 2012 at 6:25 PM, <cmp@chromium.org> wrote:

> lgtm with nit
>
>
> https://chromiumcodereview.**appspot.com/10695024/diff/1/**
>
build/gdb-add-index<https://chromiumcodereview.appspot.com/10695024/diff/1/build/gdb-add-index>
> File build/gdb-add-index (right):
>
> https://chromiumcodereview.**appspot.com/10695024/diff/1/**
>
build/gdb-add-index#newcode26<https://chromiumcodereview.appspot.com/10695024/diff/1/build/gdb-add-index#newcode26>
> build/gdb-add-index:26: objcopy --add-section
>
> .gdb_index="${file}.gdb-index" --set-section-flags .gdb_index=readonly
> "$file" "$file"
> nit: can you wrap this at 80 chars?
>
>
https://chromiumcodereview.**appspot.com/10695024/<https://chromiumcodereview...
>

[cmp, 2012-06-28 01:26:52]

lgtm then

[Steve Block, 2012-07-06 09:58:17]

Hi Albert,

This is third-party code, so should be in a 'third_party' directory. See
http://www.chromium.org/developers/adding-3rd-party-libraries. Perhaps
build/third_party/redhat/gdb-add-index?

This is particularly important in this case, as the file has a GPL v3 license,
which can be problematic.