Issue 10695012: Addressing remaining Breakpad integration issues:

Issue 10695012: Addressing remaining Breakpad integration issues: (Closed)

Created:
8 years, 5 months ago by alexeypa (please no reviews)

Modified:
8 years, 5 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Addressing remaining Breakpad integration issues: - Offer to enable crash dump reporting when the host is not installed yet. - Do not log anything until logging is initialized to avoid Application Verifier errors. BUG=130678 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144588

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback and rebased. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	remoting/host/plugin/daemon_controller_win.cc	View	1	2 chunks	+12 lines, -2 lines	0 comments	Download
	M	remoting/host/usage_stats_consent_win.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jamie

lgtm--loops good to me ;) https://chromiumcodereview.appspot.com/10695012/diff/1/remoting/host/plugin/daemon_controller_win.cc File remoting/host/plugin/daemon_controller_win.cc (right): https://chromiumcodereview.appspot.com/10695012/diff/1/remoting/host/plugin/daemon_controller_win.cc#newcode656 remoting/host/plugin/daemon_controller_win.cc:656: // The host in ...

8 years, 5 months ago (2012-06-27 21:02:20 UTC) #2

alexeypa (please no reviews)

https://chromiumcodereview.appspot.com/10695012/diff/1/remoting/host/plugin/daemon_controller_win.cc File remoting/host/plugin/daemon_controller_win.cc (right): https://chromiumcodereview.appspot.com/10695012/diff/1/remoting/host/plugin/daemon_controller_win.cc#newcode656 remoting/host/plugin/daemon_controller_win.cc:656: // The host in installed and does not support ...

8 years, 5 months ago (2012-06-27 21:26:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10695012/6001

8 years, 5 months ago (2012-06-27 21:32:40 UTC) #4

Change committed as 144588

Expand Messages | Collapse Messages