Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 10695003: Disable using the Spelling service when spellchecking text on Mac. (Closed)

Created:
8 years, 6 months ago by Hironori Bono
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Disable using the Spelling service when spellchecking text on Mac. This change makes SpellingServiceClient::IsAvailable(SPELLCHECK) return false on Mac when the spellchecker language is English because Mac uses NSSpellChecker for this case. BUG=none TEST=SpellingServiceClientTest.AvailableServices Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144653

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/spellchecker/spelling_service_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Hironori Bono
Greetings Avi and Morita-san, I notice a bonehead mistake of my r142102 <http://crrev.com/142102> today. Would ...
8 years, 6 months ago (2012-06-27 08:59:03 UTC) #1
Hajime Morrita
lgtm. Just for curiosity, when does the locate become empty?
8 years, 6 months ago (2012-06-27 09:03:31 UTC) #2
Hironori Bono
Greetings Morita-san, Thanks for your review. This locale becomes empty on unit tests. (TestingProfile returns ...
8 years, 6 months ago (2012-06-27 09:05:48 UTC) #3
Hajime Morrita
Got it! Thanks for answering.
8 years, 6 months ago (2012-06-27 09:08:22 UTC) #4
Avi (use Gerrit)
lgtm
8 years, 5 months ago (2012-06-27 14:42:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/10695003/5003
8 years, 5 months ago (2012-06-28 00:29:25 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-06-28 02:54:50 UTC) #7
Change committed as 144653

Powered by Google App Engine
This is Rietveld 408576698