Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 10694170: Renamed .pak and .rc files (Closed)

Created:
8 years, 5 months ago by Harry McCleave
Modified:
8 years, 4 months ago
CC:
chromium-reviews, pam+watch_chromium.org, sadrul, ben+watch_chromium.org, Ian Vollick, grt+watch_chromium.org, amit, jonathan.backer, jam, apatrick_chromium, joi+watch-content_chromium.org, robertshield, oshima+watch_chromium.org, piman+watch_chromium.org, darin-cc_chromium.org, tfarina, jshin+watch_chromium.org
Visibility:
Public.

Description

Renamed resource files to be more verbose, specifically: ui_resources_standard.pak => ui_resources_100_percent.pak ui_resources_2x.pak => ui_resources_200_percent.pak ui_resources_standard.rc => ui_resources_100_percent.rc theme_resources_standard.pak => theme_resources_100_percent.pak theme_resources_2x.pak => theme_resources_200_percent.pak theme_resources_standard.rc => theme_resources_100_percent.rc BUG=120185 TEST=run chome,ash_shell confirm assets loaded Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148232

Patch Set 1 #

Total comments: 3

Patch Set 2 : .rc -> _100_percent.rc #

Patch Set 3 : Rebase #

Patch Set 4 : Line length correction. #

Patch Set 5 : Missing files #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase (part 2) #

Patch Set 8 : Merge of patch 4, 7 #

Patch Set 9 : #

Patch Set 10 : Line Length for Mac #

Patch Set 11 : Whitespace error #

Patch Set 12 : Whitespace error (Attempt 2) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -99 lines) Patch
M ash/ash.gyp View 1 2 3 4 5 6 7 9 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 3 4 5 6 7 9 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser_tests.isolate View 1 2 3 4 5 9 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 4 5 6 7 9 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_resources.gyp View 5 6 7 9 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 9 7 chunks +14 lines, -14 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 2 3 4 5 9 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/gpu/test_support_gpu.gypi View 1 2 3 4 5 6 7 9 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/tools/build/chromeos/FILES.cfg View 1 2 3 4 9 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/tools/build/linux/FILES.cfg View 1 2 3 4 9 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 2 3 4 5 9 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/unit_tests.isolate View 1 2 3 4 5 6 9 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 5 6 7 9 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 2 3 4 5 6 7 9 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/aura.gyp View 1 5 6 7 9 4 chunks +4 lines, -4 lines 0 comments Download
M ui/base/resource/resource_bundle_android.cc View 1 2 3 5 6 7 9 1 chunk +4 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_aurax11.cc View 1 2 3 5 6 7 9 1 chunk +15 lines, -8 lines 0 comments Download
M ui/base/resource/resource_bundle_gtk.cc View 1 2 3 5 6 7 9 1 chunk +4 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_mac.mm View 1 2 3 4 5 6 7 8 9 10 1 chunk +8 lines, -8 lines 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 1 2 3 5 6 7 9 1 chunk +8 lines, -6 lines 0 comments Download
M ui/base/strings/ui_strings.gyp View 5 6 7 9 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.gyp View 1 5 6 7 9 1 chunk +1 line, -1 line 0 comments Download
M ui/resources/ui_resources.grd View 1 2 5 6 7 9 1 chunk +5 lines, -5 lines 0 comments Download
M ui/test/test_suite.cc View 5 6 7 9 1 chunk +1 line, -1 line 0 comments Download
M ui/ui_unittests.gypi View 1 2 3 4 5 6 7 9 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 1 2 3 4 5 6 7 9 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 2 3 4 5 6 7 9 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 41 (0 generated)
Harry McCleave
Please take a look.
8 years, 5 months ago (2012-07-12 22:27:57 UTC) #1
sail
Thanks for doing this! +benrg who's also updating the resource pak files. https://chromiumcodereview.appspot.com/10694170/diff/1/ash/ash.gyp File ash/ash.gyp ...
8 years, 5 months ago (2012-07-12 22:36:42 UTC) #2
benrg
LGTM with the RC files renamed. https://chromiumcodereview.appspot.com/10694170/diff/1/ash/ash.gyp File ash/ash.gyp (right): https://chromiumcodereview.appspot.com/10694170/diff/1/ash/ash.gyp#newcode451 ash/ash.gyp:451: '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_resources.rc', On 2012/07/12 ...
8 years, 5 months ago (2012-07-12 22:51:08 UTC) #3
grt (UTC plus 2)
rubber-stamp lgtm for chrome_frame
8 years, 5 months ago (2012-07-16 07:29:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10694170/3004
8 years, 5 months ago (2012-07-16 20:56:26 UTC) #5
commit-bot: I haz the power
Presubmit check for 10694170-3004 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-16 20:56:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10694170/3004
8 years, 5 months ago (2012-07-16 20:57:06 UTC) #7
commit-bot: I haz the power
Presubmit check for 10694170-3004 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-16 20:57:19 UTC) #8
sail
Hi Harry, is this ready for another look? If so please reply to the CL ...
8 years, 5 months ago (2012-07-17 14:05:43 UTC) #9
sail
Also, please expand the CL description to explicitly list all the files that have changed. ...
8 years, 5 months ago (2012-07-17 14:06:42 UTC) #10
Harry McCleave
On 2012/07/17 14:06:42, sail wrote: > Also, please expand the CL description to explicitly list ...
8 years, 5 months ago (2012-07-17 22:09:56 UTC) #11
sail
On 2012/07/17 22:09:56, Harry McCleave wrote: > On 2012/07/17 14:06:42, sail wrote: > > Also, ...
8 years, 5 months ago (2012-07-17 22:24:51 UTC) #12
Harry McCleave
On 2012/07/12 22:51:08, benrg wrote: > LGTM with the RC files renamed. > > https://chromiumcodereview.appspot.com/10694170/diff/1/ash/ash.gyp ...
8 years, 5 months ago (2012-07-18 01:03:05 UTC) #13
Harry McCleave
On 2012/07/16 07:29:13, grt wrote: > rubber-stamp lgtm for chrome_frame Please take a look at ...
8 years, 5 months ago (2012-07-18 01:03:22 UTC) #14
sail
LGTM!
8 years, 5 months ago (2012-07-18 01:15:12 UTC) #15
darin (slow to review)
LGTM
8 years, 5 months ago (2012-07-18 06:03:40 UTC) #16
sky
LGTM
8 years, 5 months ago (2012-07-18 14:54:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10694170/18002
8 years, 5 months ago (2012-07-18 18:07:05 UTC) #18
commit-bot: I haz the power
Change committed as 147288
8 years, 5 months ago (2012-07-18 19:13:11 UTC) #19
Harry McCleave
On 2012/07/18 19:13:11, I haz the power (commit-bot) wrote: > Change committed as 147288 Change ...
8 years, 5 months ago (2012-07-23 20:29:47 UTC) #20
sail
On 2012/07/23 20:29:47, Harry McCleave wrote: > On 2012/07/18 19:13:11, I haz the power (commit-bot) ...
8 years, 5 months ago (2012-07-23 20:34:38 UTC) #21
Harry McCleave
On 2012/07/23 20:34:38, sail wrote: > On 2012/07/23 20:29:47, Harry McCleave wrote: > > On ...
8 years, 5 months ago (2012-07-23 20:39:10 UTC) #22
sail
On 2012/07/23 20:39:10, Harry McCleave wrote: > On 2012/07/23 20:34:38, sail wrote: > > On ...
8 years, 5 months ago (2012-07-23 20:47:47 UTC) #23
Harry McCleave
On 2012/07/23 20:47:47, sail wrote: > On 2012/07/23 20:39:10, Harry McCleave wrote: > > On ...
8 years, 5 months ago (2012-07-23 20:52:10 UTC) #24
sail
On 2012/07/23 20:52:10, Harry McCleave wrote: > On 2012/07/23 20:47:47, sail wrote: > > On ...
8 years, 5 months ago (2012-07-23 20:55:29 UTC) #25
Harry McCleave
On 2012/07/23 20:55:29, sail wrote: > On 2012/07/23 20:52:10, Harry McCleave wrote: > > On ...
8 years, 5 months ago (2012-07-23 20:57:57 UTC) #26
sail
On 2012/07/23 20:57:57, Harry McCleave wrote: > On 2012/07/23 20:55:29, sail wrote: > > On ...
8 years, 5 months ago (2012-07-23 21:05:21 UTC) #27
Harry McCleave
On 2012/07/23 21:05:21, sail wrote: > On 2012/07/23 20:57:57, Harry McCleave wrote: > > On ...
8 years, 5 months ago (2012-07-23 21:28:21 UTC) #28
sail
LGTM!
8 years, 5 months ago (2012-07-23 21:42:07 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10694170/32004
8 years, 5 months ago (2012-07-23 22:22:57 UTC) #30
commit-bot: I haz the power
Presubmit check for 10694170-32004 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-23 22:23:16 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10694170/38003
8 years, 5 months ago (2012-07-23 22:38:30 UTC) #32
commit-bot: I haz the power
Presubmit check for 10694170-38003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-23 22:38:53 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10694170/26004
8 years, 5 months ago (2012-07-23 23:22:56 UTC) #34
commit-bot: I haz the power
Try job failure for 10694170-26004 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-24 00:55:44 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10694170/26004
8 years, 4 months ago (2012-07-24 17:23:53 UTC) #36
commit-bot: I haz the power
Try job failure for 10694170-26004 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-07-24 18:39:33 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10694170/26004
8 years, 4 months ago (2012-07-24 20:32:23 UTC) #38
commit-bot: I haz the power
Try job failure for 10694170-26004 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-07-24 21:52:06 UTC) #39
Emmanuel Saint-loubert-Bié
lgtm LGTM will land by hand, since CQ us not cooperating.
8 years, 4 months ago (2012-07-24 22:13:48 UTC) #40
commit-bot: I haz the power
8 years, 4 months ago (2012-07-24 22:15:03 UTC) #41

Powered by Google App Engine
This is Rietveld 408576698