Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: lib/unittest/unittest.dart

Issue 10694146: Added ability to disable logging in mocks, to avoid the memory overhead if you don't need behavior … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/unittest/mock.dart ('k') | tests/lib/unittest/instance_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/unittest/unittest.dart
===================================================================
--- lib/unittest/unittest.dart (revision 9562)
+++ lib/unittest/unittest.dart (working copy)
@@ -360,7 +360,7 @@
// Always run except if the test is done.
if (_testCase.isComplete) {
_testCase.error(
- 'Callback called after already being marked as done ($_calls)',
+ 'Callback called after already being marked as done ($_calls).',
'');
_state = _UNCAUGHT_ERROR;
return false;
@@ -387,7 +387,8 @@
return _callback(arg0, arg1, arg2, arg3);
} else {
_testCase.error(
- 'unittest lib does not support callbacks with more than 4 arguments',
+ 'unittest lib does not support callbacks with more than'
+ ' 4 arguments.',
'');
_state = _UNCAUGHT_ERROR;
}
@@ -433,7 +434,7 @@
if (_calls > _expectedCalls) {
_testCase.error(
'Callback called more times than expected '
- '($_calls > $_expectedCalls)',
+ '($_calls > $_expectedCalls).',
'');
_state = _UNCAUGHT_ERROR;
return false;
@@ -592,7 +593,7 @@
final expected = testCase.callbacks;
testCase.error(
'More calls to _handleAllCallbacksDone() than expected. '
- 'Actual: ${_callbacksCalled}, expected: ${expected}', '');
+ 'Actual: ${_callbacksCalled}, expected: ${expected}.', '');
_state = _UNCAUGHT_ERROR;
} else if ((_callbacksCalled == testCase.callbacks) &&
(_state != _RUNNING_TEST)) {
« no previous file with comments | « lib/unittest/mock.dart ('k') | tests/lib/unittest/instance_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698