Added ability to disable logging in mocks, to avoid the memory overhead if you don't need behavior …

Added ability to disable logging in mocks, to avoid the memory overhead if you don't need behavior verification of the mock itself.
Changed exceptions to end with periods - seems more Darty.
Committed: https://code.google.com/p/dart/source/detail?r=9575

[Siggi Cherem (dart-lang), 2012-07-11 22:46:04]

lgtm

http://chromiumcodereview.appspot.com/10694146/diff/1/lib/unittest/mock.dart
File lib/unittest/mock.dart (right):

http://chromiumcodereview.appspot.com/10694146/diff/1/lib/unittest/mock.dart#...
lib/unittest/mock.dart:826: if (log != null) {
why not continbue using the flag? ('if (logging)' reads more nicely)

[gram, 2012-07-11 23:24:07]

PTAL. I made it possible to turn logging on/off on the fly. The main
questionable area is this:

- should we always allocate a log, and if logging is never enabled it will just
be empty?
- should we allocate a log lazily, only when logging is first enabled, and if
logging is never enabled treat getLogs() etc as an error?

I went with the latter approach.

http://chromiumcodereview.appspot.com/10694146/diff/1/lib/unittest/mock.dart
File lib/unittest/mock.dart (right):

http://chromiumcodereview.appspot.com/10694146/diff/1/lib/unittest/mock.dart#...
lib/unittest/mock.dart:826: if (log != null) {
On 2012/07/11 22:46:04, sigmund wrote:
> why not continbue using the flag? ('if (logging)' reads more nicely)

You're right - I originally didn't mean to make the flag a member. Given that I
did, I should use it; we could even have the logging turned on and off at
different times.

[Siggi Cherem (dart-lang), 2012-07-11 23:29:37]

lgtm