Reverse OmniboxViewViews::HandleMouseReleaseEvent selection.

Reverse OmniboxViewViews::HandleMouseReleaseEvent selection.

Clicking in the Omnibox (without prior focus or selection) should select-all in reverse to show the leading text.

Note: OmniboxViewViews selection differs from OmniboxViewWin in other tangentially related ways (retention and display of unfocused selection, tracked in crbug.com/134701).

BUG=134762, 134701
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146239

[msw, 2012-07-11 20:44:45]

Please take a look; thanks!

[Peter Kasting, 2012-07-11 20:49:17]

LGTM

https://chromiumcodereview.appspot.com/10694140/diff/1/chrome/browser/ui/view...
File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right):

https://chromiumcodereview.appspot.com/10694140/diff/1/chrome/browser/ui/view...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:400: // Select-all in
reverse to show the leading omnibox text on mouse release.
Nit: The Windows comment is:

    // Select all in the reverse direction so as not to scroll the caret
    // into view and shift the contents jarringly.

[msw, 2012-07-11 21:46:29]

https://chromiumcodereview.appspot.com/10694140/diff/1/chrome/browser/ui/view...
File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right):

https://chromiumcodereview.appspot.com/10694140/diff/1/chrome/browser/ui/view...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:400: // Select-all in
reverse to show the leading omnibox text on mouse release.
On 2012/07/11 20:49:17, Peter Kasting wrote:
> Nit: The Windows comment is:
> 
>     // Select all in the reverse direction so as not to scroll the caret
>     // into view and shift the contents jarringly.

Done.

[commit-bot: I haz the power, 2012-07-11 21:46:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10694140/4001

[commit-bot: I haz the power, 2012-07-11 23:36:16]

Change committed as 146239