Issue 10694129: Re-land "Removed one copy-n-paste clone of HGraphBuilder::BuildStoreNamed."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10694129: Re-land "Removed one copy-n-paste clone of HGraphBuilder::BuildStoreNamed." (Closed)

Created:
8 years, 5 months ago by Sven Panne

Modified:
8 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Re-land "Removed one copy-n-paste clone of HGraphBuilder::BuildStoreNamed." The previous CL used the wrong map in some cases, leading to a wrong decision regarding monomorphic usage and therefore some performance regressions. Committed: https://code.google.com/p/v8/source/detail?r=12037

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -39 lines)			Patch
	M	src/hydrogen.h	View		1 chunk	+2 lines, -4 lines	0 comments	Download
	M	src/hydrogen.cc	View		8 chunks	+20 lines, -35 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages