Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

Issue 10694126: Revert 146032 - [Sync] Check if bookmark exists before attempting favicon update (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/glue/bookmark_change_processor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
===================================================================
--- chrome/browser/sync/profile_sync_service_bookmark_unittest.cc (revision 146039)
+++ chrome/browser/sync/profile_sync_service_bookmark_unittest.cc (working copy)
@@ -543,10 +543,6 @@
model_->bookmark_bar_node()->id());
}
- int64 GetSyncIdFromChromeNode(const BookmarkNode* node) {
- return model_associator_->GetSyncIdFromChromeId(node->id());
- }
-
private:
// Used by both |ui_thread_| and |file_thread_|.
MessageLoop message_loop_;
@@ -1499,27 +1495,6 @@
model_->RemoveObserver(&observer);
}
-TEST_F(ProfileSyncServiceBookmarkTest, FaviconUpdateToDeletedBookmark) {
- LoadBookmarkModel(DELETE_EXISTING_STORAGE, DONT_SAVE_TO_STORAGE);
- const BookmarkNode* bnode = model_->AddURL(
- model_->bookmark_bar_node(),
- 0,
- ASCIIToUTF16("Internets #1 Pies Site"),
- GURL("http://www.easypie.com/"));
- StartSync();
-
- {
- syncer::WriteTransaction trans(FROM_HERE, test_user_share_.user_share());
- FakeServerChange dels(&trans);
- dels.Delete(GetSyncIdFromChromeNode(bnode));
- dels.ApplyPendingChanges(change_processor_.get());
- }
-
- // Now update the favicon locally. This should have no effect, but should
- // not result in an error either.
- change_processor_->BookmarkNodeFaviconChanged(model_, bnode);
-}
-
} // namespace
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/glue/bookmark_change_processor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698