Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: media/base/pipeline.cc

Issue 10694125: Remove stale TODO + unnecessary if-guard in Pipeline::DoSeek(). (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline.cc
diff --git a/media/base/pipeline.cc b/media/base/pipeline.cc
index fd59a130db6fcf3341a845d4ab96952e7513f5cb..9c456bb2751cd0814706d2f80b19f214836de8a6 100644
--- a/media/base/pipeline.cc
+++ b/media/base/pipeline.cc
@@ -1227,16 +1227,8 @@ void Pipeline::OnDemuxerStopDone(const base::Closure& callback) {
}
void Pipeline::DoSeek(TimeDelta seek_timestamp) {
- // TODO(acolwell): We might be able to convert this if (demuxer_) into a
- // DCHECK(). Further investigation is needed to make sure this won't introduce
- // a bug.
- if (demuxer_) {
- demuxer_->Seek(seek_timestamp, base::Bind(
- &Pipeline::OnDemuxerSeekDone, this, seek_timestamp));
- return;
- }
-
- OnDemuxerSeekDone(seek_timestamp, PIPELINE_OK);
+ demuxer_->Seek(seek_timestamp, base::Bind(
+ &Pipeline::OnDemuxerSeekDone, this, seek_timestamp));
}
void Pipeline::OnDemuxerSeekDone(TimeDelta seek_timestamp,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698