Issue 10694125: Remove stale TODO + unnecessary if-guard in Pipeline::DoSeek().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10694125: Remove stale TODO + unnecessary if-guard in Pipeline::DoSeek(). (Closed)

Created:
8 years, 5 months ago by scherkus (not reviewing)

Modified:
8 years, 5 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove stale TODO + unnecessary if-guard in Pipeline::DoSeek(). If we call DoSeek() without a demuxer we've clearly got issues as we shouldn't be seeking without a demuxer so crashing is preferable. BUG=none TEST=none TBR=acolwell Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146024

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -10 lines)			Patch
	M	media/base/pipeline.cc	View		1 chunk	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

8 years, 5 months ago (2012-07-11 01:36:32 UTC) #1

Split this off from http://codereview.chromium.org/10753021/ in case this does
end up crashing I don't want the AR patch to get reverted :)

Expand Messages | Collapse Messages