Source/WebCore/html/HTMLSelectElement.cpp - Issue 10694124: Merge 122082 - Heap-use-after-free in WebCore::RenderObject::destroyAndCleanupAnonymousWrappers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/html/HTMLSelectElement.cpp

Issue 10694124: Merge 122082 - Heap-use-after-free in WebCore::RenderObject::destroyAndCleanupAnonymousWrappers (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1180/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebCore/html/HTMLSelectElement.cpp

===================================================================

--- Source/WebCore/html/HTMLSelectElement.cpp (revision 122284)

+++ Source/WebCore/html/HTMLSelectElement.cpp (working copy)

@@ -346,7 +346,11 @@

bool HTMLSelectElement::childShouldCreateRenderer(const NodeRenderingContext& childContext) const

{

- return childContext.isOnUpperEncapsulationBoundary() && HTMLFormControlElementWithState::childShouldCreateRenderer(childContext);

+ if (!HTMLFormControlElementWithState::childShouldCreateRenderer(childContext))

+ return false;

+ if (!usesMenuList())

+ return true;

+ return validationMessageShadowTreeContains(childContext.node());

}

HTMLOptionsCollection* HTMLSelectElement::options()

« no previous file with comments | « Source/WebCore/html/HTMLFormControlElement.cpp ('k') | Source/WebCore/html/ValidationMessage.h » ('j') | no next file with comments »