Issue 10694121: Revert 146011 - aura: Change long press affordance according to UX mocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10694121: Revert 146011 - aura: Change long press affordance according to UX mocks. (Closed)

Created:
8 years, 5 months ago by Mihai Parparita -not on Chrome

Modified:
8 years, 5 months ago

Reviewers:
varunjain

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 146011 - aura: Change long press affordance according to UX mocks. BUG=125875 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10758015 TBR=varunjain@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146018

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -150 lines)			Patch
	M	ash/wm/system_gesture_event_filter.cc	View		5 chunks	+32 lines, -149 lines	0 comments	Download
	M	ui/base/gestures/gesture_configuration.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

8 years, 5 months ago (2012-07-11 01:06:04 UTC) #2

Reverted due to build errors:
http://build.chromium.org/p/chromium/builders/Win%20Aura/builds/16958/steps/c...


6>wm\system_gesture_event_filter.cc(57):error C2220: warning treated as error -
no 'object' file generated
6>wm\system_gesture_event_filter.cc(57): warning C4305: 'initializing' :
truncation from 'double' to 'const float'
6>wm\system_gesture_event_filter.cc(59): warning C4305: 'initializing' :
truncation from 'double' to 'const float'
6>wm\system_gesture_event_filter.cc(60): warning C4305: 'initializing' :
truncation from 'double' to 'const float'
6>wm\system_gesture_event_filter.cc(235):error C2057: expected constant
expression
6>wm\system_gesture_event_filter.cc(235):error C2466: cannot allocate an array
of constant size 0
6>wm\system_gesture_event_filter.cc(235):error C2133: 'colors' : unknown size

Expand Messages | Collapse Messages