Issue 10694118: Add shortcuts for keyboard brightness

Issue 10694118: Add shortcuts for keyboard brightness (Closed)

Created:
8 years, 5 months ago by Yusuke Sato

Modified:
8 years, 5 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add shortcuts for keyboard brightness. - Add a delegate interface for controlling keyboard brightness. - Call the interface on Alt+F6 and Alt+F7. BUG=135482 TEST=added some tests to aura_shell_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146004

Patch Set 1 #

Patch Set 2 : add ash.gyp #

Patch Set 3 : review #

Total comments: 2

Patch Set 4 : review fix #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -0 lines)			Patch
M	ash/accelerators/accelerator_controller.h	View	1 2	3 chunks	+6 lines, -0 lines	0 comments	Download
M	ash/accelerators/accelerator_controller.cc	View	1 2	3 chunks	+18 lines, -0 lines	0 comments	Download
M	ash/accelerators/accelerator_controller_unittest.cc	View	1 2	3 chunks	+81 lines, -0 lines	0 comments	Download
M	ash/accelerators/accelerator_table.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/accelerators/accelerator_table.cc	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	ash/ash.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h	View	1 2 3	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

Could you have a look at this? Two more CLs (against chrome/browser/ui/views/ash/ and chromeos/dbus/) will ...

8 years, 5 months ago (2012-07-10 22:04:05 UTC) #1

Daniel Erat

LGTM with a nit. http://codereview.chromium.org/10694118/diff/4003/ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h File ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h (right): http://codereview.chromium.org/10694118/diff/4003/ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h#newcode21 ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h:21: // brightness. nit: describe what ...

8 years, 5 months ago (2012-07-10 22:47:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10694118/8002

8 years, 5 months ago (2012-07-10 22:57:47 UTC) #3

Yusuke Sato

http://codereview.chromium.org/10694118/diff/4003/ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h File ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h (right): http://codereview.chromium.org/10694118/diff/4003/ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h#newcode21 ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h:21: // brightness. On 2012/07/10 22:47:33, Daniel Erat wrote: > ...

8 years, 5 months ago (2012-07-10 22:57:50 UTC) #4

Change committed as 146004

Expand Messages | Collapse Messages