chrome/browser/extensions/api/identity/web_auth_flow.h - Issue 10694111: RefCounted types should not have public destructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/web_auth_flow.h

Issue 10694111: RefCounted types should not have public destructors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix android & Win compiles Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/identity/web_auth_flow.h

diff --git a/chrome/browser/extensions/api/identity/web_auth_flow.h b/chrome/browser/extensions/api/identity/web_auth_flow.h

index 92054fd2a50a9b13e62ff7778298f1f6d25f764e..c5013316e0dd9f4199ae534af5ba1c3e33606b15 100644

--- a/chrome/browser/extensions/api/identity/web_auth_flow.h

+++ b/chrome/browser/extensions/api/identity/web_auth_flow.h

@@ -51,7 +51,8 @@ class WebAuthFlow : public content::WebContentsDelegate,

// the flow.

virtual void OnAuthFlowFailure() = 0;

- virtual ~Delegate() { }

+ protected:

+ virtual ~Delegate() {}

};

// Interceptor interface for testing.