Issue 10694108: Make EventBindings use static routed methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10694108: Make EventBindings use static routed methods. (Closed)

Created:
8 years, 5 months ago by koz (OOO until 15th September)

Modified:
8 years, 5 months ago

Reviewers:

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make EventBindings use static routed methods. This change makes EventBindings use NativeHandler::RouteStaticFunction() instead of NativeHandler::RouteFunction() because use of the latter seems to cause use after free errors (see bug). This change was originally done in r132850 but it was reverted in r133253 because it introduced many crashes. In r145484 as part of a bigger change (filtered events) the events were made to use dynamic routing again and many crashes ensued again. BUG=136232 TBR=kalman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145634

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -57 lines)			Patch
M	chrome/renderer/extensions/event_bindings.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/renderer/extensions/event_bindings.cc	View	15 chunks	+50 lines, -48 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10694108/1

8 years, 5 months ago (2012-07-08 06:47:14 UTC) #1

Change committed as 145634

Expand Messages | Collapse Messages