Issue 10694107: Revert 145523 - Add a policy to disable proceeding through the Safe Browsing interstitials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10694107: Revert 145523 - Add a policy to disable proceeding through the Safe Browsing interstitials. (Closed)

Created:
8 years, 5 months ago by cpu_(ooo_6.6-7.5)

Modified:
8 years, 5 months ago

Reviewers:
Joao da Silva

CC:
chromium-reviews, MAD, jar (doing other things), Nirnimesh, anantha, pam+watch_chromium.org, arv (Not doing code reviews), dyu1, dennis_jeffrey, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 145523 - Add a policy to disable proceeding through the Safe Browsing interstitials. BUG=119184 TEST=browser_tests:SafeBrowsingBlockingPageTest.*, Safe Browsing warning pages don't have a "proceed" link when opening malware sites (e.g. ianfette.org) and the policy is set Review URL: https://chromiumcodereview.appspot.com/10694037 TBR=joaodasilva@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145622

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -196 lines)			Patch
M	chrome/app/policy/policy_templates.json	View	3 chunks	+4 lines, -16 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_handler_list.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/profiles/profile.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/safe_browsing_malware_block.html	View	1 chunk	+7 lines, -16 lines	0 comments	Download
MM	chrome/browser/resources/safe_browsing_multiple_threat_block.html	View	2 chunks	+20 lines, -43 lines	0 comments	Download
M	chrome/browser/resources/safe_browsing_phishing_block.html	View	1 chunk	+6 lines, -20 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_blocking_page.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_blocking_page.cc	View	6 chunks	+24 lines, -25 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc	View	5 chunks	+0 lines, -53 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/test/functional/policy_test_cases.py	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/tools/chromeactions.txt	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/tools/extract_actions.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

8 years, 5 months ago (2012-07-08 13:51:35 UTC) #2

lgtm.

Turns out document.readyState is different in Debug after NavigateToURL(); for
some reason jstemplate isn't done when the test inspects the page.

Expand Messages | Collapse Messages