chrome/browser/speech/speech_input_extension_api.cc - Issue 10694106: Added support for multiple parameters to Extension API callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/speech_input_extension_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Review fixes. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/speech/speech_input_extension_api.cc

diff --git a/chrome/browser/speech/speech_input_extension_api.cc b/chrome/browser/speech/speech_input_extension_api.cc

index 23afea06e5754a6be9643b6973bd877119390652..0f8d423fcc45d58c578e4da3b2ea85e718d7c2bf 100644

--- a/chrome/browser/speech/speech_input_extension_api.cc

+++ b/chrome/browser/speech/speech_input_extension_api.cc

@@ -168,7 +168,7 @@ bool StopSpeechInputFunction::RunImpl() {

void IsRecordingSpeechInputFunction::SetResult(bool result) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

- result_.reset(Value::CreateBooleanValue(result));

+ SetSingleResult(Value::CreateBooleanValue(result));

SendResponse(true);

}

« chrome/browser/extensions/extension_function.h ('K') | « chrome/browser/speech/extension_api/tts_extension_api.cc ('k') | no next file » | no next file with comments »