chrome/browser/extensions/extension_module.cc - Issue 10694106: Added support for multiple parameters to Extension API callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_module.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Review fixes. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_function.h ('K') | « chrome/browser/extensions/extension_management_api_browsertest.cc ('k') | chrome/browser/extensions/extension_page_capture_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_module.cc

diff --git a/chrome/browser/extensions/extension_module.cc b/chrome/browser/extensions/extension_module.cc

index cd35b4298939bbf566ea1b56a672afb636d5eb6e..3f67eefd93024f5d95db18fe7ddb89ccbe3c4469 100644

--- a/chrome/browser/extensions/extension_module.cc

+++ b/chrome/browser/extensions/extension_module.cc

@@ -26,7 +26,7 @@ bool IsAllowedIncognitoAccessFunction::RunImpl() {

ExtensionService* ext_service = profile()->GetExtensionService();

const extensions::Extension* extension = GetExtension();

- result_.reset(Value::CreateBooleanValue(

+ SetSingleResult(Value::CreateBooleanValue(

ext_service->IsIncognitoEnabled(extension->id())));

return true;

}

@@ -35,7 +35,7 @@ bool IsAllowedFileSchemeAccessFunction::RunImpl() {

ExtensionService* ext_service = profile()->GetExtensionService();

const extensions::Extension* extension = GetExtension();

- result_.reset(Value::CreateBooleanValue(

- ext_service->AllowFileAccess(extension)));

+ SetSingleResult(Value::CreateBooleanValue(

+ ext_service->AllowFileAccess(extension)));

return true;

}