chrome/browser/extensions/api/usb/usb_api.cc - Issue 10694106: Added support for multiple parameters to Extension API callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/usb/usb_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Review fixes. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/terminal/terminal_private_api.cc ('k') | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc » ('j') | chrome/browser/extensions/extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/usb/usb_api.cc

diff --git a/chrome/browser/extensions/api/usb/usb_api.cc b/chrome/browser/extensions/api/usb/usb_api.cc

index a11b0c557fd87eca68e6ca997cbf10f3c263f638..55cd2f9c882ad3d04cb34d23fb8bca7c7aad355a 100644

--- a/chrome/browser/extensions/api/usb/usb_api.cc

+++ b/chrome/browser/extensions/api/usb/usb_api.cc

@@ -46,7 +46,7 @@ void UsbFindDeviceFunction::Work() {

UsbDevice* const device = service->FindDevice(parameters_->vendor_id,

parameters_->product_id);

if (!device) {

- result_.reset(base::Value::CreateNullValue());

+ SetSingleResult(base::Value::CreateNullValue());

return;

}

@@ -57,7 +57,7 @@ void UsbFindDeviceFunction::Work() {

result.handle = controller()->AddAPIResource(resource);

result.vendor_id = parameters_->vendor_id;

result.product_id = parameters_->product_id;

- result_ = result.ToValue();

+ SetSingleResult(FindDevice::Result::Create(result));

}

bool UsbFindDeviceFunction::Respond() {