chrome/browser/extensions/api/file_system/file_system_api.cc - Issue 10694106: Added support for multiple parameters to Extension API callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Review fixes. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_actions_api.cc ('k') | chrome/browser/extensions/api/identity/identity_api.cc » ('j') | chrome/browser/extensions/extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/file_system/file_system_api.cc

diff --git a/chrome/browser/extensions/api/file_system/file_system_api.cc b/chrome/browser/extensions/api/file_system/file_system_api.cc

index 871125e0030030d2aab9d8263ef184ef5e896dbb..fe913375d170f28731c5f755951e1aed9d314189 100644

--- a/chrome/browser/extensions/api/file_system/file_system_api.cc

+++ b/chrome/browser/extensions/api/file_system/file_system_api.cc

@@ -148,7 +148,7 @@ bool FileSystemGetDisplayPathFunction::RunImpl() {

return false;

file_path = PrettifyPath(file_path);

- result_.reset(base::Value::CreateStringValue(file_path.value()));

+ SetSingleResult(base::Value::CreateStringValue(file_path.value()));

return true;

}

@@ -200,7 +200,7 @@ void FileSystemEntryFunction::RegisterFileSystemAndSendResponse(

policy->GrantReadFile(renderer_id, path);

DictionaryValue* dict = new DictionaryValue();

- result_.reset(dict);

+ SetSingleResult(dict);

dict->SetString("fileSystemId", filesystem_id);

dict->SetString("baseName", path.BaseName().AsUTF8Unsafe());

SendResponse(true);