Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Review fixes. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc
index 49e8f77f553440ca3f2a4d7be78c38cf922222d9..dc89d1322895fb24272a321d2ff391ab80562138 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc
@@ -544,7 +544,7 @@ void DownloadsDownloadFunction::OnStarted(DownloadId dl_id, net::Error error) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
VLOG(1) << __FUNCTION__ << " " << dl_id << " " << error;
if (dl_id.local() >= 0) {
- result_.reset(base::Value::CreateIntegerValue(dl_id.local()));
+ SetSingleResult(base::Value::CreateIntegerValue(dl_id.local()));
} else {
error_ = net::ErrorToString(error);
}
@@ -677,7 +677,7 @@ bool DownloadsSearchFunction::RunInternal() {
scoped_ptr<base::DictionaryValue> item(DownloadItemToJSON(*it));
json_results->Append(item.release());
}
- result_.reset(json_results);
+ SetSingleResult(json_results);
return true;
}
@@ -911,7 +911,7 @@ void DownloadsGetFileIconFunction::OnIconURLExtracted(const std::string& url) {
if (url.empty())
error_ = download_extension_errors::kIconNotFoundError;
else
- result_.reset(base::Value::CreateStringValue(url));
+ SetSingleResult(base::Value::CreateStringValue(url));
SendResponse(error_.empty());
}

Powered by Google App Engine
This is Rietveld 408576698