chrome/browser/infobars/infobar_extension_api.cc - Issue 10694106: Added support for multiple parameters to Extension API callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/infobars/infobar_extension_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Synced. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_function.cc ('K') | « chrome/browser/history/top_sites_extension_test.cc ('k') | chrome/browser/rlz/rlz_extension_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/infobars/infobar_extension_api.cc

diff --git a/chrome/browser/infobars/infobar_extension_api.cc b/chrome/browser/infobars/infobar_extension_api.cc

index 027a3cd7ac62ecf395073099dbf08c77347092a0..f3b256f17d5eb7a101dddf54c5b4568d761b82ef 100644

--- a/chrome/browser/infobars/infobar_extension_api.cc

+++ b/chrome/browser/infobars/infobar_extension_api.cc

@@ -74,7 +74,7 @@ bool ShowInfoBarFunction::RunImpl() {

// TODO(finnur): Return the actual DOMWindow object. Bug 26463.

DCHECK(browser->extension_window_controller());

- result_.reset(browser->extension_window_controller()->CreateWindowValue());

+ SetResult(browser->extension_window_controller()->CreateWindowValue());

return true;

}