chrome/browser/extensions/system/system_api.cc - Issue 10694106: Added support for multiple parameters to Extension API callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/system/system_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Synced. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_function.cc ('K') | « chrome/browser/extensions/settings/settings_api.cc ('k') | chrome/browser/history/history_extension_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/system/system_api.cc

diff --git a/chrome/browser/extensions/system/system_api.cc b/chrome/browser/extensions/system/system_api.cc

index 042eb3566775c28b4d083a956b1e1b9de96c65f8..14923a3dd5a5faa136b517b86d87de2ee89d1a97 100644

--- a/chrome/browser/extensions/system/system_api.cc

+++ b/chrome/browser/extensions/system/system_api.cc

@@ -73,8 +73,7 @@ bool GetIncognitoModeAvailabilityFunction::RunImpl() {

EXTENSION_FUNCTION_VALIDATE(

value >= 0 &&

value < static_cast<int>(arraysize(kIncognitoModeAvailabilityStrings)));

- result_.reset(

- Value::CreateStringValue(kIncognitoModeAvailabilityStrings[value]));

+ SetResult(Value::CreateStringValue(kIncognitoModeAvailabilityStrings[value]));

return true;

}

@@ -134,7 +133,7 @@ bool GetUpdateStatusFunction::RunImpl() {

DictionaryValue* dict = new DictionaryValue();

dict->SetString(kStateKey, state);

dict->SetDouble(kDownloadProgressKey, download_progress);

- result_.reset(dict);

+ SetResult(dict);

return true;

}