Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4915)

Unified Diff: chrome/browser/extensions/extension_management_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Synced. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management_api.cc
diff --git a/chrome/browser/extensions/extension_management_api.cc b/chrome/browser/extensions/extension_management_api.cc
index 1fd716bee96d8c4c1151126aa1d326b0779bcc1c..197396934bd07fb88802548a484f25143c4e9310 100644
--- a/chrome/browser/extensions/extension_management_api.cc
+++ b/chrome/browser/extensions/extension_management_api.cc
@@ -162,7 +162,7 @@ static void AddExtensionInfo(ListValue* list,
bool GetAllExtensionsFunction::RunImpl() {
ListValue* result = new ListValue();
- result_.reset(result);
+ SetResult(result);
AddExtensionInfo(result, *service()->extensions(), service());
AddExtensionInfo(result, *service()->disabled_extensions(), service());
@@ -180,7 +180,7 @@ bool GetExtensionByIdFunction::RunImpl() {
return false;
}
DictionaryValue* result = CreateExtensionInfo(*extension, service());
- result_.reset(result);
+ SetResult(result);
return true;
}
@@ -201,7 +201,7 @@ bool GetPermissionWarningsByIdFunction::RunImpl() {
for (PermissionMessages::const_iterator i = warnings.begin();
i < warnings.end(); ++i)
result->Append(Value::CreateStringValue(i->message()));
- result_.reset(result);
+ SetResult(result);
return true;
}
@@ -325,7 +325,7 @@ void GetPermissionWarningsByManifestFunction::OnParseSuccess(
for (PermissionMessages::const_iterator i = warnings.begin();
i < warnings.end(); ++i)
result->Append(Value::CreateStringValue(i->message()));
- result_.reset(result);
+ SetResult(result);
SendResponse(true);
// Matched with AddRef() in RunImpl().

Powered by Google App Engine
This is Rietveld 408576698