chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc - Issue 10694106: Added support for multiple parameters to Extension API callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Synced. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_api.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_api.h » ('j') | chrome/browser/extensions/extension_function.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc

diff --git a/chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc b/chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc

index 834bad0491936b57dbfe6701a8d78920d03a2ec6..30b45ed3f2eaa0001a81243637ad896e01e2cad2 100644

--- a/chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc

+++ b/chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc

@@ -95,7 +95,7 @@ void WebSocketProxyPrivate::ResolveHostIOPart(IOThread* io_thread) {

bool WebSocketProxyPrivate::RunImpl() {

AddRef();

- result_.reset(Value::CreateStringValue(""));

+ SetResult(Value::CreateStringValue(""));

#if defined(OS_CHROMEOS)

bool delay_response = false;

@@ -165,7 +165,7 @@ void WebSocketProxyPrivateGetURLForTCPFunction::CustomFinalize() {

StringValue* url = Value::CreateStringValue(std::string(

"ws://127.0.0.1:" + base::IntToString(listening_port_) +

"/tcpproxy?" + query));

- result_.reset(url);

+ SetResult(url);

#endif

}

@@ -201,7 +201,7 @@ void WebSocketProxyPrivateGetPassportForTCPFunction::CustomFinalize() {

"web_socket_proxy", map_) + std::string(":");

if (ContainsKey(map_, "addr"))

passport += map_["addr"];

- result_.reset(Value::CreateStringValue(passport));

+ SetResult(Value::CreateStringValue(passport));

#endif

}