Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: chrome/browser/extensions/api/terminal/terminal_private_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Synced. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/terminal/terminal_private_api.cc
diff --git a/chrome/browser/extensions/api/terminal/terminal_private_api.cc b/chrome/browser/extensions/api/terminal/terminal_private_api.cc
index 91e14834e80615880384d0d8e4e52be63d98d439..976220d97b6200fe1bd30f9e5cbcb8cecbb3df8c 100644
--- a/chrome/browser/extensions/api/terminal/terminal_private_api.cc
+++ b/chrome/browser/extensions/api/terminal/terminal_private_api.cc
@@ -117,7 +117,7 @@ void OpenTerminalProcessFunction::OpenOnFileThread() {
SendInputToTerminalProcessFunction::~SendInputToTerminalProcessFunction() {}
void OpenTerminalProcessFunction::RespondOnUIThread(pid_t pid) {
- result_.reset(new base::FundamentalValue(pid));
+ SetResult(new base::FundamentalValue(pid));
SendResponse(true);
}
@@ -147,7 +147,7 @@ void SendInputToTerminalProcessFunction::SendInputOnFileThread(pid_t pid,
}
void SendInputToTerminalProcessFunction::RespondOnUIThread(bool success) {
- result_.reset(new base::FundamentalValue(success));
+ SetResult(new base::FundamentalValue(success));
SendResponse(true);
}
@@ -176,7 +176,7 @@ void CloseTerminalProcessFunction::CloseOnFileThread(pid_t pid) {
}
void CloseTerminalProcessFunction::RespondOnUIThread(bool success) {
- result_.reset(new base::FundamentalValue(success));
+ SetResult(new base::FundamentalValue(success));
SendResponse(true);
}
@@ -217,6 +217,6 @@ void OnTerminalResizeFunction::OnResizeOnFileThread(pid_t pid,
}
void OnTerminalResizeFunction::RespondOnUIThread(bool success) {
- result_.reset(new base::FundamentalValue(success));
+ SetResult(new base::FundamentalValue(success));
SendResponse(true);
}

Powered by Google App Engine
This is Rietveld 408576698