Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: chrome/browser/extensions/api/record/record_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Synced. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/record/record_api.cc
diff --git a/chrome/browser/extensions/api/record/record_api.cc b/chrome/browser/extensions/api/record/record_api.cc
index 1ebed8c4b67b977094e13131f6bb627f2664ff78..1a0bcd19ae2baa87ae8739dbfe841d282f711f5e 100644
--- a/chrome/browser/extensions/api/record/record_api.cc
+++ b/chrome/browser/extensions/api/record/record_api.cc
@@ -53,7 +53,7 @@ bool RunPageCyclerFunction::RunImpl() {
// parameter parsing) then return a list of such errors, else perform
// RunTestBrowser on the BlockingPool.
if (!errors_.empty()) {
- result_.reset(record::CaptureURLs::Result::Create(errors_));
+ SetResult(record::CaptureURLs::Result::Create(errors_));
SendResponse(true);
} else {
content::BrowserThread::PostBlockingPoolTask(FROM_HERE,
@@ -180,7 +180,7 @@ void CaptureURLsFunction::AddSwitches(CommandLine* line) {
}
void CaptureURLsFunction::Finish() {
- result_.reset(record::CaptureURLs::Result::Create(errors_));
+ SetResult(record::CaptureURLs::Result::Create(errors_));
SendResponse(true);
}
@@ -247,7 +247,7 @@ void ReplayURLsFunction::Finish() {
result.stats = stats_;
result.errors = errors_;
- result_.reset(record::ReplayURLs::Result::Create(result));
+ SetResult(record::ReplayURLs::Result::Create(result));
SendResponse(true);
}

Powered by Google App Engine
This is Rietveld 408576698