chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc - Issue 10694106: Added support for multiple parameters to Extension API callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Synced. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/media_gallery/media_gallery_api.cc ('k') | chrome/browser/extensions/api/permissions/permissions_api.cc » ('j') | chrome/browser/extensions/extension_function.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

diff --git a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

index 28bb985a08579b75e27a34a384c97cb7f9e36a98..c2b4571eb428a2dde5856a2dfe92d4f65f2fa80b 100644

--- a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

+++ b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

@@ -513,7 +513,7 @@ bool CreateOffscreenTabFunction::RunImpl() {

// TODO(alexbost): Maybe the callback is called too soon. It should probably

// be called once we have navigated to the url.

if (has_callback()) {

- result_.reset(offscreen_tab.CreateValue());

+ SetResult(offscreen_tab.CreateValue());

SendResponse(true);

}

@@ -535,7 +535,7 @@ bool GetOffscreenTabFunction::RunImpl() {

return false;

}

- result_.reset(offscreen_tab->CreateValue());

+ SetResult(offscreen_tab->CreateValue());

return true;

}

@@ -555,7 +555,7 @@ bool GetAllOffscreenTabFunction::RunImpl() {

tab_list->Append((*i)->CreateValue());

}

- result_.reset(tab_list);

+ SetResult(tab_list);

return true;

}