chrome/browser/extensions/api/dns/dns_api.cc - Issue 10694106: Added support for multiple parameters to Extension API callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/dns/dns_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Synced. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/discovery/discovery_api_unittest.cc ('k') | chrome/browser/extensions/api/dns/dns_apitest.cc » ('j') | chrome/browser/extensions/extension_function.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/dns/dns_api.cc

diff --git a/chrome/browser/extensions/api/dns/dns_api.cc b/chrome/browser/extensions/api/dns/dns_api.cc

index 063873adfe6b2e2ad5b1fab09bc16b44f77ccbc9..4b9f3541c7ca110026ed8adeb744e57b84736a21 100644

--- a/chrome/browser/extensions/api/dns/dns_api.cc

+++ b/chrome/browser/extensions/api/dns/dns_api.cc

@@ -85,7 +85,7 @@ void DnsResolveFunction::OnLookupFinished(int resolve_result) {

resolve_info->address.reset(

new std::string(addresses_->front().ToStringWithoutPort()));

}

- result_.reset(Resolve::Result::Create(*resolve_info));

+ SetResult(Resolve::Result::Create(*resolve_info));

response_ = true;

bool post_task_result = BrowserThread::PostTask(