Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: chrome/browser/extensions/api/browsing_data/browsing_data_test.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Synced. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/browsing_data/browsing_data_test.cc
diff --git a/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc b/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc
index a6b4ec579d123748b6d34aa4de19627ab85615ab..1d39a5d146d4cf0bd7119dad1404463928bb64b6 100644
--- a/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc
+++ b/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc
@@ -21,7 +21,7 @@
#include "content/public/browser/notification_service.h"
using extension_function_test_utils::RunFunctionAndReturnError;
-using extension_function_test_utils::RunFunctionAndReturnResult;
+using extension_function_test_utils::RunFunctionAndReturnSingleResult;
namespace {
@@ -76,8 +76,10 @@ class ExtensionBrowsingDataTest : public InProcessBrowserTest,
const std::string& key,
int expected_mask) {
SCOPED_TRACE(key);
- EXPECT_EQ(NULL, RunFunctionAndReturnResult(new RemoveBrowsingDataFunction(),
- std::string("[{\"since\": 1}, {\"") + key + "\": true}]", browser()));
+ EXPECT_EQ(NULL, RunFunctionAndReturnSingleResult(
+ new RemoveBrowsingDataFunction(),
+ std::string("[{\"since\": 1}, {\"") + key + "\": true}]",
+ browser()));
EXPECT_EQ(expected_mask, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginSetMask());
}
@@ -86,7 +88,8 @@ class ExtensionBrowsingDataTest : public InProcessBrowserTest,
const std::string& protectedStr,
int expected_mask) {
SCOPED_TRACE(protectedStr);
- EXPECT_EQ(NULL, RunFunctionAndReturnResult(new RemoveBrowsingDataFunction(),
+ EXPECT_EQ(NULL, RunFunctionAndReturnSingleResult(
+ new RemoveBrowsingDataFunction(),
"[{\"originType\": " + protectedStr + "}, {\"cookies\": true}]",
browser()));
EXPECT_EQ(expected_mask, GetOriginSetMask());
@@ -116,8 +119,10 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowsingDataTest, OneAtATime) {
// Use-after-free, see http://crbug.com/116522
IN_PROC_BROWSER_TEST_F(ExtensionBrowsingDataTest,
DISABLED_RemoveBrowsingDataAll) {
- EXPECT_EQ(NULL, RunFunctionAndReturnResult(new RemoveBrowsingDataFunction(),
- kRemoveEverythingArguments, browser()));
+ EXPECT_EQ(NULL, RunFunctionAndReturnSingleResult(
+ new RemoveBrowsingDataFunction(),
+ kRemoveEverythingArguments,
+ browser()));
EXPECT_EQ(base::Time::FromDoubleT(1.0), GetBeginTime());
EXPECT_EQ((BrowsingDataRemover::REMOVE_SITE_DATA |

Powered by Google App Engine
This is Rietveld 408576698