Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Indentation fixes and comment. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
index 1d11a788b5647b1971f8317a87c1be8fcabd010c..b1ac7eafb88a9aaedd4a1298cce278f74d168718 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -319,28 +319,28 @@ bool BeginInstallWithManifestFunction::RunImpl() {
void BeginInstallWithManifestFunction::SetResult(ResultCode code) {
switch (code) {
case ERROR_NONE:
- result_.reset(Value::CreateStringValue(""));
+ SetSingleResult(Value::CreateStringValue(""));
break;
case UNKNOWN_ERROR:
- result_.reset(Value::CreateStringValue("unknown_error"));
+ SetSingleResult(Value::CreateStringValue("unknown_error"));
break;
case USER_CANCELLED:
- result_.reset(Value::CreateStringValue("user_cancelled"));
+ SetSingleResult(Value::CreateStringValue("user_cancelled"));
break;
case MANIFEST_ERROR:
- result_.reset(Value::CreateStringValue("manifest_error"));
+ SetSingleResult(Value::CreateStringValue("manifest_error"));
break;
case ICON_ERROR:
- result_.reset(Value::CreateStringValue("icon_error"));
+ SetSingleResult(Value::CreateStringValue("icon_error"));
break;
case INVALID_ID:
- result_.reset(Value::CreateStringValue("invalid_id"));
+ SetSingleResult(Value::CreateStringValue("invalid_id"));
break;
case PERMISSION_DENIED:
- result_.reset(Value::CreateStringValue("permission_denied"));
+ SetSingleResult(Value::CreateStringValue("permission_denied"));
break;
case INVALID_ICON_URL:
- result_.reset(Value::CreateStringValue("invalid_icon_url"));
+ SetSingleResult(Value::CreateStringValue("invalid_icon_url"));
break;
default:
CHECK(false);
@@ -552,7 +552,7 @@ void SilentlyInstallFunction::OnExtensionInstallFailure(
}
bool GetBrowserLoginFunction::RunImpl() {
- result_.reset(CreateLoginResult(profile_->GetOriginalProfile()));
+ SetSingleResult(CreateLoginResult(profile_->GetOriginalProfile()));
return true;
}
@@ -561,9 +561,9 @@ bool GetStoreLoginFunction::RunImpl() {
ExtensionPrefs* prefs = service->extension_prefs();
std::string login;
if (prefs->GetWebStoreLogin(&login)) {
- result_.reset(Value::CreateStringValue(login));
+ SetSingleResult(Value::CreateStringValue(login));
} else {
- result_.reset(Value::CreateStringValue(std::string()));
+ SetSingleResult(Value::CreateStringValue(std::string()));
}
return true;
}
@@ -586,7 +586,7 @@ GetWebGLStatusFunction::GetWebGLStatusFunction() {
GetWebGLStatusFunction::~GetWebGLStatusFunction() {}
void GetWebGLStatusFunction::CreateResult(bool webgl_allowed) {
- result_.reset(Value::CreateStringValue(
+ SetSingleResult(Value::CreateStringValue(
webgl_allowed ? "webgl_allowed" : "webgl_blocked"));
}

Powered by Google App Engine
This is Rietveld 408576698