chrome/browser/extensions/api/media_gallery/media_gallery_api.cc - Issue 10694106: Added support for multiple parameters to Extension API callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/media_gallery/media_gallery_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Indentation fixes and comment. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/idltest/idltest_api.cc ('k') | chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc » ('j') | chrome/browser/extensions/extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/media_gallery/media_gallery_api.cc

diff --git a/chrome/browser/extensions/api/media_gallery/media_gallery_api.cc b/chrome/browser/extensions/api/media_gallery/media_gallery_api.cc

index 9485eb59d4e8a06480c5af4919b5b6bf30500882..efd2a5fcb474c6cd0f95c446ad4db6ca59b77726 100644

--- a/chrome/browser/extensions/api/media_gallery/media_gallery_api.cc

+++ b/chrome/browser/extensions/api/media_gallery/media_gallery_api.cc

@@ -59,7 +59,7 @@ bool GetMediaFileSystemsFunction::RunImpl() {

policy->GrantReadFileSystem(child_id, fsid);

}

- result_.reset(list);

+ SetSingleResult(list);

return true;

}

@@ -67,7 +67,7 @@ OpenMediaGalleryManagerFunction::~OpenMediaGalleryManagerFunction() {}

bool OpenMediaGalleryManagerFunction::RunImpl() {

// TODO(vandebo) Open the Media Gallery Manager UI.

- result_.reset(Value::CreateNullValue());

+ SetSingleResult(Value::CreateNullValue());

return true;

}

@@ -75,7 +75,7 @@ AssembleMediaFileFunction::~AssembleMediaFileFunction() {}

bool AssembleMediaFileFunction::RunImpl() {

// TODO(vandebo) Update the metadata and return the new file.

- result_.reset(Value::CreateNullValue());

+ SetSingleResult(Value::CreateNullValue());

return true;

}